Skip to content

update insight playground nav #6840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2025
Merged

update insight playground nav #6840

merged 1 commit into from
Apr 24, 2025

Conversation

@iuwqyir
Copy link
Contributor

@iuwqyir iuwqyir commented Apr 24, 2025 •
edited
Loading

[Dashboard] Feature: Update API endpoint names and add NFT balances endpoint

Notes for the reviewer

This PR makes the following changes to the insight blueprints:

  • Renames "Get token transfers by wallet address" to "Get token transfers"
  • Renames "Get NFT transfers by owner" to "Get NFT transfers"
  • Adds a new endpoint "Get NFT balances by address" with path "/v1/nfts/balance/{ownerAddress}"

How to test

Verify the updated endpoint names and new NFT balances endpoint appear correctly in the dashboard.

@vercel vercel bot temporarily deployed to Preview – wallet-ui April 24, 2025 16:21 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 24, 2025 16:21 Inactive
@vercel
Copy link

vercel bot commented Apr 24, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2025 4:23pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Apr 24, 2025 4:23pm
login ⬜️ Skipped (Inspect) Apr 24, 2025 4:23pm
thirdweb-www ⬜️ Skipped (Inspect) Apr 24, 2025 4:23pm
wallet-ui ⬜️ Skipped (Inspect) Apr 24, 2025 4:23pm

@vercel vercel bot temporarily deployed to Preview – docs-v2 April 24, 2025 16:21 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www April 24, 2025 16:21 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Apr 24, 2025

⚠️ No Changeset found

Latest commit: 2e57e26

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Playground Changes involving the Playground codebase. label Apr 24, 2025
@iuwqyir Graphite App
Copy link
Contributor Author

iuwqyir commented Apr 24, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@iuwqyir iuwqyir requested review from MananTank and jnsdls April 24, 2025 16:21
@iuwqyir iuwqyir marked this pull request as ready for review April 24, 2025 16:21
@iuwqyir iuwqyir requested review from a team as code owners April 24, 2025 16:21
@codecov
Copy link

codecov bot commented Apr 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.30%. Comparing base (1d598ce) to head (2e57e26).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6840   +/-   ##
=======================================
  Coverage   55.30%   55.30%           
=======================================
  Files         896      896           
  Lines       57023    57023           
  Branches     3968     3968           
=======================================
  Hits        31536    31536           
  Misses      25390    25390           
  Partials       97       97
Flag Coverage Δ
packages 55.30% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 24, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 51.16 KB (0%) 1.1 s (0%) 205 ms (+219.41% 🔺) 1.3 s
thirdweb (cjs) 143.77 KB (0%) 2.9 s (0%) 357 ms (+93.07% 🔺) 3.3 s
thirdweb (minimal + tree-shaking) 5.66 KB (0%) 114 ms (0%) 74 ms (+1084.83% 🔺) 188 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 32 ms (+1774.61% 🔺) 43 ms
thirdweb/react (minimal + tree-shaking) 19.33 KB (0%) 387 ms (0%) 90 ms (+750.04% 🔺) 477 ms

@joaquim-verges joaquim-verges merged commit 7809c62 into main Apr 24, 2025
26 checks passed
@joaquim-verges joaquim-verges deleted the 04-24-update_insight_playground_nav branch April 24, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls Awaiting requested review from jnsdls

@MananTank MananTank Awaiting requested review from MananTank

Assignees

@iuwqyir iuwqyir

Labels

Playground Changes involving the Playground codebase.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iuwqyir @joaquim-verges